Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix conditions #278

Merged
merged 2 commits into from Jul 20, 2023
Merged

Conversation

fiorafran
Copy link

Descripción del requerimiento

Esta rompiendo el validador

Descripción de la solución

Me estaba pisando las properties en los if, dejando sin las demas props que necesitan los condicionales.

  • Separe las props base en una constante y le paso el spread a properties

Cómo se puede probar?

  • npm t
  • node index.js validate -i tests/mocks/schemas/schema-name.yml (reemplazar nombre del schema y extension)

@colomfernando colomfernando merged commit f2e7a97 into master Jul 20, 2023
4 checks passed
@colomfernando colomfernando deleted the JMV-3051-dynamicValue-schema-validator branch July 20, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants