Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing the interface of Video class #8

Closed
janjiss opened this issue Jan 11, 2013 · 1 comment
Closed

Changing the interface of Video class #8

janjiss opened this issue Jan 11, 2013 · 1 comment
Labels
enhancement

Comments

@janjiss
Copy link
Owner

janjiss commented Jan 11, 2013

Maybe we should consider passing hash with args for creating instance of Conred::Video, instead of simple arguments? It would be more clear (at least for me) if it looked like:

 Conred::Video(
    :url => video_url, :error_message => "Video url is not valid",
    :width => 350, :height => 350
 )

Would that be more prefferable, than current interface, where we just pass anonymous args?
alexcp added a commit to alexcp/conred that referenced this issue Jan 12, 2013
@alexcp
Constructor now take an hash of arguments and refactoring of the spec
74053d0 
  Some of the spec where making multiple assertions in the same "it" and
  instantiating multiple object with the same value

  fix janjiss#8
@janjiss
Copy link
Owner Author

janjiss commented Jan 15, 2013

This was fixed

@janjiss janjiss closed this as completed Jan 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@janjiss