Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build multple targets #114

Merged
merged 4 commits into from Mar 10, 2023
Merged

Build multple targets #114

merged 4 commits into from Mar 10, 2023

Conversation

jankapunkt
Copy link
Owner

Summary

This implements #107 and makes the package ready to be published for CommonJs, ECMA Script Modules (ES6+ and ES5) and IIFE (ES5) for max. browser compatibility.

The demo is also now fully ES5+IIFE and should run on even older browsers, as long as they support Promises.

The new structure is

  • src - contains all source files for development
  • dist - containts all build outputs
  • docs - contains all demo related files

The import structure might be breaking for some people, although the main, browser and exports fields have been updated in package.json.

Linked issue(s)

Involved parts of the project

all

Added tests?

nothing changed here

Webspeech API standard

nothing changed here

Reproduction

  • npm run build
  • npm run build:demo

@jankapunkt jankapunkt linked an issue Feb 21, 2023 that may be closed by this pull request
@andre-dietrich
Copy link
Contributor

Hi, sorry for the delay ... I tested it with multiple languages and settings ... works like charm ...

output.mp4

Copy link
Contributor

@andre-dietrich andre-dietrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As before mentioned ... works great ... I think I don't have write access, that is why the review is still pending ...

@jankapunkt jankapunkt merged commit afc08cc into master Mar 10, 2023
@jankapunkt
Copy link
Owner Author

@andre-dietrich thank you! I have merged and will create a new release on npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build for multiple targets
2 participants