Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add quiet flag to init fn to silently fail on error #155

Merged
merged 2 commits into from Jun 13, 2023

Conversation

jankapunkt
Copy link
Owner

Summary

This adds a quiet boolean flag to the EasySpeech.init function in order
to fail only with the error logged to the console but still resolving the Promise.

Linked issue(s)

#64

Involved parts of the project

init

Added tests?

yes

Webspeech API standard

Reproduction

  • clone, run tests
  • include in code, call init with quiet flag on a browser that has no speech synthesis, like Opera

@jankapunkt jankapunkt added the enhancement New feature or request label Jun 6, 2023
@jankapunkt jankapunkt linked an issue Jun 6, 2023 that may be closed by this pull request
@jankapunkt jankapunkt added help wanted Extra attention is needed reviewer wanted labels Jun 9, 2023
@jankapunkt jankapunkt merged commit b1c4ef1 into master Jun 13, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed reviewer wanted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Find a way for robots/crawlers to not cause an error due to init fails
1 participant