fix: Support for KaiOS 2.5 #83 #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andre-dietrich
force-pushed
the
fix-kaios_support
branch
from
e9fd53f
to
225e663
Compare
Two changes were necessary to run easy-speech on KaiOS: 1. An additional KaiOS check is added, based on the user navigator, this if it succeeds, it is treated as a isFirefox. The original test fails, since KaiOS (2.5) uses version 49, an older one. However, the TTS functionality is the same. 2. `globalThis` is not defined in KaiOS 2.5, which causes a ReferenceError and thus, the entire lib to fail. That is why an additional check was added. However, the resulting output still needs to be transpiled with babel, since the KaiOS browser does not support es6 syntax.
andre-dietrich
force-pushed
the
fix-kaios_support
branch
from
225e663
to
4c7ac0e
Compare
jankapunkt
reviewed
Jan 4, 2023
jankapunkt
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes were necessary to run easy-speech on KaiOS:
globalThisis not defined in KaiOS 2.5, which causes a ReferenceError and thus, the entire lib to fail. That is why an additional check was added.However, the resulting output still needs to be transpiled with babel, since the KaiOS browser does not support es6 syntax.