Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added email and href linking functions to sidebar cv #13

Merged
merged 2 commits into from
Nov 3, 2018
Merged

added email and href linking functions to sidebar cv #13

merged 2 commits into from
Nov 3, 2018

Conversation

Gunner62
Copy link
Contributor

@Gunner62 Gunner62 commented Nov 2, 2018

Added two new functions to sidebar cv for linking. Also recompiled the PDF for the new links.

@jankapunkt
Copy link
Owner

Hey @Gunner62 congratulations for your first PR! The code looks well so far. However, when vieewing the downloaded the pdf file I found, that the hyperlinks have the default light-bueish borders around them (they don't appear in the preview on GitHub and also maybe not in a Tex Editor preview but for example when opening them using a PDF reader).

There is a good thread on tex.stackexchange about how to remove these borders.

You can just "extend your code", because the PR is not fixed. This means you can continue to modify your code in the fork, change things, commit changes and push again to master (which is the branch of your fork you used to open this PR). The changes will automatically appear here.

Thanks a lot for your contribution. If you need further help just let me know.

@Gunner62
Copy link
Contributor Author

Gunner62 commented Nov 2, 2018

Hey @jankapunkt thanks for the help! I added another commit to fix the problem you mentioned.
Cheers 😄

@jankapunkt jankapunkt merged commit 5e0cbc0 into jankapunkt:master Nov 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants