Sinatra + Thin + ActiveRecord ConnectionManagement do not work

[mrrusof]

Consider the following example Sinatra API.

#!/usr/bin/env ruby                                                                                  

require 'sinatra'
require 'active_record'

ActiveRecord::Base.establish_connection(
adapter:  'sqlite3',
database: 'newsletter.db'
)

ActiveRecord::Schema.define do
  create_table :subscribers do |t|
    t.string :email
    t.timestamps
  end
end

class Subscriber < ActiveRecord::Base
  validates :email, presence: true
end

class Newsletter < Sinatra::Base

  set :server, :thin
  use ActiveRecord::ConnectionAdapters::ConnectionManagement

  get '/subscribers/:email' do
    s = Subscriber.find_by_email(params[:email])
    if s == nil
      status 404
    else
      content_type 'application/json'
      s.to_json
    end
  end

  post '/subscribers/:email' do
    Subscriber.create(email: params[:email])
  end

end

Newsletter.run!

The API returns either a subscriber or a 404 the first 5 times I GET a subscriber. The 6th time I get a timeout. After each of the first 5 GETs, there is one more read+write file descriptor open for newsletter.db. I would expect there to be only one all the time.

The reason for the timeout is that Thin starts processing each request in a thread and finishes processing the request in another thread. ConnectionManagement only returns to the pool those connections that are active for the current thread and Thin applies ConnectionManagement in the second thread instead of the first.

Do you think it makes sense to provide the following version of ConnectionManagement in gem sinatra-activerecord?

class ConnectionManagement
  def initialize(app)
    @app = app
  end

  def call(env)
    testing = env['rack.test']
    response = @app.call(env)
    ActiveRecord::Base.clear_active_connections! unless testing
    response
  rescue Exception
    ActiveRecord::Base.clear_active_connections! unless testing
    raise
  end
end

[mrrusof]

Related questions in stackoverflow:

• ActiveRecord::ConnectionTimeoutError
• ActiveRecord connection warning. (Database connections will not be closed automatically)
• How do I reuse connections in ActiveRecord?

[mrrusof]

Corresponding issue in Thin: macournoyer/thin#307

[mrrusof]

Resolved by in corresponding issue in Thin.