Fix reloading .vimrc by introducing test#custom_runners

It's not right that "test#runners" is used both for setting custom
runners and later vim-test extends it with default runners. This causes
issues with reloading .vimrc when custom runners are used.

So instead users should use the new "test#custom_runners" variable, and
this time the list of runners will be dynamically generated, which means
it will work better with .vimrc reloading.

We still keep backwards compatibility with setting "test#runners".

Fixes #306

README.md

@@ -379,7 +379,7 @@ First, add your runner to the list in your `.vimrc`:
 
 ```vim
 " First letter of runner's name must be uppercase
-let test#runners = {'MyLanguage': ['MyRunner']}
+let test#custom_runners = {'MyLanguage': ['MyRunner']}
 ```
 
 Second, create `~/.vim/autoload/test/mylanguage/myrunner.vim`, and define the following
@@ -412,7 +412,7 @@ let test#enabled_runners = ["mylanguage#myrunner", "ruby#rspec"]
 
 All other runners will not be loaded.
 
-Note that for your own custom runners, you still need to set `test#runners`.
+Note that for your own custom runners, you still need to set `test#custom_runners`.
 
 ## Running tests
 

autoload/test.vim

@@ -112,7 +112,7 @@ function! test#shell(cmd, strategy) abort
 endfunction
 
 function! test#determine_runner(file) abort
-  for [language, runners] in items(g:test#runners)
+  for [language, runners] in items(test#get_runners())
     for runner in runners
       let runner = tolower(language).'#'.tolower(runner)
       if exists("g:test#enabled_runners")
@@ -127,6 +127,18 @@ function! test#determine_runner(file) abort
   endfor
 endfunction
 
+function! test#get_runners() abort
+  if exists('g:test#runners')
+    let custom_runners = g:test#runners
+  elseif exists('g:test#custom_runners')
+    let custom_runners = g:test#custom_runners
+  else
+    let custom_runners = {}
+  endif
+
+  return s:extend(custom_runners, g:test#default_runners)
+endfunction
+
 function! test#test_file(file) abort
   return !empty(test#determine_runner(a:file))
 endfunction
@@ -186,3 +198,14 @@ function! s:echo_failure(message) abort
   echo a:message
   echohl None
 endfunction
+
+function! s:extend(source, dict) abort
+  let result = {}
+  for [key, value] in items(a:source)
+    let result[key] = value
+  endfor
+  for [key, value] in items(a:dict)
+    let result[key] = get(result, key, []) + value
+  endfor
+  return result
+endfunction

doc/test.txt

@@ -427,7 +427,7 @@ let test#enabled_runners = ["mylanguage#myrunner", "ruby#rspec"]
 
 All other runners will not be loaded.
 
-Note that for your own custom runners, you still need to set `test#runners`.
+Note that for your own custom runners, you still need to set `test#custom_runners`.
 
 Test.vim relies on you being cd-ed into the project root. However, sometimes
 you may want to execute tests from a different directory than the current

plugin/test.vim

@@ -5,14 +5,7 @@ let g:loaded_test = 1
 
 let g:test#plugin_path = expand('<sfile>:p:h:h')
 
-function! s:extend(source, dict) abort
-  for [key, value] in items(a:dict)
-    let a:source[key] = get(a:source, key, []) + value
-  endfor
-endfunction
-
-let g:test#runners = get(g:, 'test#runners', {})
-call s:extend(g:test#runners, {
+let g:test#default_runners = {
   \ 'Ruby':       ['Rails', 'M', 'Minitest', 'RSpec', 'Cucumber'],
   \ 'JavaScript': ['Ava', 'CucumberJS', 'Intern', 'TAP', 'Karma', 'Lab', 'Mocha', 'Jasmine', 'Jest', 'WebdriverIO'],
   \ 'Python':     ['DjangoTest', 'PyTest', 'PyUnit', 'Nose', 'Nose2'],
@@ -32,7 +25,7 @@ call s:extend(g:test#runners, {
   \ 'Racket':     ['RackUnit'],
   \ 'Java':       ['MavenTest'],
   \ 'Crystal':    ['CrystalSpec'],
-\})
+\}
 
 let g:test#custom_strategies = get(g:, 'test#custom_strategies', {})
 let g:test#custom_transformations = get(g:, 'test#custom_transformations', {})
@@ -44,7 +37,7 @@ command! -nargs=* -bar TestSuite   call test#run('suite', split(<q-args>))
 command! -nargs=* -bar TestLast    call test#run_last(split(<q-args>))
 command!          -bar TestVisit   call test#visit()
 
-for [s:language, s:runners] in items(g:test#runners)
+for [s:language, s:runners] in items(test#get_runners())
   for s:runner in s:runners
     if index(g:test#runner_commands, s:runner) != -1
       if exists(':'.s:runner) | continue | endif