bug: cache actually not working

[aruku7230]

When parsing a template with the same tags second time, because of cache, it should return the cached tokens.

test code:

  describe('when parsing a template with the same tags second time, return the cached tokens', function () {
    it('returns the same tokens for the latter parse', function () {
      var template = '{{foo}}[bar]';
      var parsedResult1 = Mustache.parse(template);
      var parsedResult2 = Mustache.parse(template);

      assert.deepEqual(parsedResult1, parsedResult2);
      assert.ok(parsedResult1 === parsedResult2);
    });
  });

test code failed on assert.ok(parsedResult1 === parsedResult2);

[aruku7230]

The problem code may be in Writer.prototype.parse:

  Writer.prototype.parse = function parse (template, tags) {
    var cache = this.cache;
    var tokens = cache[template];

    if (tokens == null)
      tokens = cache[template + ':' + (tags || mustache.tags).join(':')] = parseTemplate(template, tags);

    return tokens;
};

The problem is the used cache key is different between the time set a cache and the time try to get a cache.

• When set a cache, the used cache key is template
• When try to get a cache, the used cache key is template + ':' + (tags || mustache.tags).join(':')

[raymond-lam]

My fault. I’ll submit a PR to fix today. Raymond Lam

…

On Jul 15, 2018, at 8:46 AM, Ashinoko ***@***.***> wrote: When parsing a template with the same tags second time, because of cache, it should return the cached tokens. test code: describe('when parsing a template with the same tags second time, return the cached tokens', function () { it('returns the same tokens for the latter parse', function () { var template = '{{foo}}[bar]'; var parsedResult1 = Mustache.parse(template); var parsedResult2 = Mustache.parse(template); assert.deepEqual(parsedResult1, parsedResult2); assert.ok(parsedResult1 === parsedResult2); }); }); test code failed on assert.ok(parsedResult1 === parsedResult2); — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[aruku7230]

No rush. Actually, I'm also writing a PR to fix it.