Bump characteristics dependency / Allow GB1988 encoding (7bit ascii-l…

…ike)
janlelis · Mar 31, 2017 · 102442d · 102442d
1 parent 398cb42
commit 102442d
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,8 +1,10 @@
 ## CHANGELOG
 
-### 2.4.1
+### 2.5.0
 
 * Double check UTF-32 only on Ruby versions which contain the bug
+* Bump characteristics dependency
+  * Allow GB1988 encoding (7bit ascii-like)
 
 ### 2.4.0
 

diff --git a/README.md b/README.md
@@ -5,7 +5,7 @@ Ruby library and CLI command that visualizes various Unicode and ASCII/single by
 - Makes analyzing encodings easier
 - Helps you with debugging strings
 - Highlights invalid/special/blank bytes/characters/codepoints
-- Supports *UTF-8*, *UTF-16LE*/*UTF-16BE*, *UTF-32LE*/*UTF-32BE*, *ISO-8859-X*, *Windows-125X*, *IBMX*, *CP85X*, *macX*, *TIS-620*/*Windows-874*, *KOI8-R*/*KOI8-U*, 7-Bit *ASCII*, and arbitrary *BINARY* data
+- Supports *UTF-8*, *UTF-16LE*/*UTF-16BE*, *UTF-32LE*/*UTF-32BE*, *ISO-8859-X*, *Windows-125X*, *IBMX*, *CP85X*, *macX*, *TIS-620*/*Windows-874*, *KOI8-R*/*KOI8-U*, 7-Bit *ASCII*/*GB1988*, and arbitrary *BINARY* data
 
 ## Color Coding
 

diff --git a/lib/unibits.rb b/lib/unibits.rb
@@ -22,6 +22,7 @@ module Unibits
       /^TIS-620$/,
       /^Windows-874$/,
       /^KOI8/,
+      /^GB1988$/,
     )
   ).sort.freeze
 

diff --git a/spec/unibits_spec.rb b/spec/unibits_spec.rb
@@ -67,6 +67,13 @@
       result.must_match "01000011"
     end
 
+    it "works with GB1988" do
+      result = Paint.unpaint(Unibits.visualize("ASCII string".force_encoding('GB1988')))
+      result.must_match "C"
+      result.must_match "43"
+      result.must_match "01000011"
+    end
+
     it "works with 'ISO-8859-X' encodings" do
       string = "\xBC Idiosyncr\xE4tic\n\x91".force_encoding("ISO-8859-1")
       result = Paint.unpaint(Unibits.visualize(string))

diff --git a/unibits.gemspec b/unibits.gemspec
@@ -20,7 +20,7 @@ Gem::Specification.new do |gem|
   gem.add_dependency 'paint', '>= 0.9', '< 3.0'
   gem.add_dependency 'unicode-display_width', '~> 1.1'
   gem.add_dependency 'symbolify', '~> 1.0'
-  gem.add_dependency 'characteristics', '>= 0.5.2'
+  gem.add_dependency 'characteristics', '>= 0.7'
   gem.add_dependency 'rationalist', '~> 2.0'
 
   gem.required_ruby_version = "~> 2.0"