Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing variable labels in read.sav? #19

Closed
iembry opened this issue Nov 11, 2021 · 3 comments
Closed

Missing variable labels in read.sav? #19

iembry opened this issue Nov 11, 2021 · 3 comments

Comments

@iembry
Copy link

iembry commented Nov 11, 2021

Greetings. In the description of the returned data.frame objects in read.sav, the following are defined:

val.label = value labels

var.label = variable labels

Within the actual R code, the following exists:

val.labels <- attribs$vallabels # line 155

attr(data, "var.label") <- val.labels # line 514

Shouldn't var.label (variable labels) be a different attribute than val.label (value labels)?

Thank you in advance.

@JanMarvin
Copy link
Owner

Hi @iembry , thanks for the issue. It might be just a wording issue, but I'll look into it

@JanMarvin
Copy link
Owner

I've updated the documentation and removed the entry to val.label. The code and documentation might not be entirely consistent (I've worked on this with larger breaks in between), but nothing is lost and everything apart from the documentation looks correct. If you want to further improve this, pull requests on code or documentation are always welcome.

@iembry
Copy link
Author

iembry commented Dec 19, 2021

@JanMarvin Thank you for making the changes to the documentation. I appreciate that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants