fix: MSG_USERAUTH_SUCCESS should be alone without extra bits #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I use tinyssh to unlock LUKS fully encrypted system remotely. I tried to use asyncssh (https://github.com/ronf/asyncssh) to automatically input the cipher passphrase from a password store, but I had a error from asyncssh even with user authentication success from tinyssh.
From a discussion with asyncssh maintainer (https://groups.google.com/forum/#!topic/asyncssh-users/5IxCDmbTqZc),
buf_putstring(b,"ssh-connection");should be removed given RFC 4252.For now, I remove the checking part in asyncssh in my computer and the unlocking tool is working. But, I think it should be in tinyssh.
Do you agree with this modification ?
Thanks,
Mehdi
Credit for this modification go to Ron Frederick :).