Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track/1.0 #23

Merged
merged 3 commits into from
May 3, 2019
Merged

Track/1.0 #23

merged 3 commits into from
May 3, 2019

Conversation

jannikbuschke
Copy link
Owner

@jannikbuschke jannikbuschke commented Apr 28, 2019

A PR to track the remaining work for a 1.0 release

  • Find solution/recommendation whether to use <form> and native button type attributes
  • Add Cascader
  • Add TreeSelect
  • Add Mention
  • Add AutoComplete
  • Create a pre-release

@joshsmith
Copy link

As part of 1.0 are you planning on having labels work? Currently, I believe that setting name is causing labels to be broken and not know what the for should be.

@jannikbuschke
Copy link
Owner Author

Can you elaborate a bit which labels you mean exactly?

@joshsmith
Copy link

joshsmith commented May 2, 2019

Can you elaborate a bit which labels you mean exactly?

Sure, here's a forked example of your CodeSandbox: https://codesandbox.io/s/y257p4l8z9

Edit: as a counter-example, look at antd's own CodeSandbox to see how the DOM differs: https://codesandbox.io/s/kw79qx5w15

The label element for [name=userName] does not have a for="userName", which breaks things like react-testing-library's getByLabelText and forces me to fallback to less optimal methods for finding and filling inputs, and breaks some browser / a11y behavior.

I have a feeling this is some sort of props issue, but honestly just have not had time to examine further.

(P.S. Thanks for making this!)

@jannikbuschke
Copy link
Owner Author

jannikbuschke commented May 2, 2019

That is some cool input. Testing (especially with react-testing-library) and a11y stuff should definitely be fixed. Im not sure how much effort it will be, and it does not necessarily need to be part of the 1.0 release. Im also fine moving forward to a 2.0 release if it makes sense, or fix things as part of 1.* releases.

@jannikbuschke jannikbuschke merged commit 8a63ceb into master May 3, 2019
@jannikbuschke
Copy link
Owner Author

accidentally merged. Recreated: #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants