Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict step according to the dimension of the simulation #7

Closed
ignasiialemany opened this issue Feb 5, 2021 · 1 comment · Fixed by #8
Closed

Restrict step according to the dimension of the simulation #7

ignasiialemany opened this issue Feb 5, 2021 · 1 comment · Fixed by #8

Comments

@ignasiialemany
Copy link
Contributor

ignasiialemany commented Feb 5, 2021 •
edited
Loading

If the user wants to run 1D or 2D simulations the step is added to all three components and is not restricted to either one/two components. Add substrate.dimension in the substrate.yml config file and pass in this information into function one_dt when the step is created. (Currently the dimension of the step is hardcoded to dim=3)
@ignasiialemany
Copy link
Contributor Author

I already have the changes done, I will create a PR

@ignasiialemany ignasiialemany changed the title Restrict stepping into other components Restrict step according to the dimension of the simulation Feb 5, 2021
@ignasiialemany ignasiialemany mentioned this issue Feb 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prescribe dimensions of step ignasiialemany/RWcDTI
1 participant
@ignasiialemany