feat(#57): footnotes

[tuurep]

Addresses the last task in #57

Can you make sure I added the yarn module in the right way? I ran yarn add markdown-it-footnote

Are these styles good? I straight up added 20px margin-top for the footnotes section. Dark mode needed a new color which is called something like fg-dimmed in a variable in Github's styling.

[jannis-baum]

Nice, looks great! I'll have a proper look tomorrow :)

For now, I replied to your question in the issue so maybe let's use a margin and font size in em/rem units? Makes it more accessible for people who need bigger text, for example. There are probably more spots where we should switch to relative units but I guess that's a problem for the future🙈

[tuurep]

Ok! I'll commit once I can figure out good values for font and margin

[tuurep]

Ah I figured it out: 0.75rem and 1.25rem

Yeah the idea to convert raw px values to rem seems good. Though I was wondering about something like: why are some of the border elements exactly 0.2px tall and is there even a difference between 0.2px and 1px

But we can merge this and think more broadly, if you want

[jannis-baum]

Yeah the idea to convert raw px values to rem seems good. Though I was wondering about something like: why are some of the border elements exactly 0.2px tall and is there even a difference between 0.2px and 1px

Good question. I just learned about it from w3.org:

The px unit is the magic unit of CSS. It is not related to the current font and usually not related to physical centimeters or inches either. The px unit is defined to be small but visible, and such that a horizontal 1px wide line can be displayed with sharp edges (no anti-aliasing). What is sharp, small and visible depends on the device and the way it is used: do you hold it close to your eyes, like a mobile phone, at arms length, like a computer monitor, or somewhere in between, like an e-book reader? The px is thus not defined as a constant length, but as something that depends on the type of device and its typical use.

[jannis-baum]

Thank you!!

[jannis-baum]

Hey @tuurep just a quick out-of-place question🙈 Is there anything else related to styles or GitHub extended markdown features you want to add/change? If not I would make a new minor release now that this is merged

[tuurep]

Yeah I have nothing to add for now, and great, I could benefit from a release right now :) Thanks