DRY workflows and ColorBar snap tick labels to nice values #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove prop precision, seems to be well handled by d3.scaleLinear.nice()
… 1 and floating or exponential for abs(num) < 1
janosh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate to reusable workflows in https://github.com/janosh/workflows.
6c6338f DRY workflows
92d4f31 update deps
2bcc499 add
test/unit/BohrAtom.test.ts30ffa40 add props
snap_ticks,ramp_points,nice_rangeto ColorBarf3ecd7e fix
ColorBar.test.tsand remove PR tomaintrigger fromgh-pages.yml3863a6c refactor
pretty_num()to used3.format()with SI units forabs(num) > 1and floating or exponential forabs(num) < 15ad957c fix type of
ElementTile.svelteprecisionprop