Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split /src/lib into submodules #36

Merged
merged 3 commits into from
Jun 28, 2023
Merged

Split /src/lib into submodules #36

merged 3 commits into from
Jun 28, 2023

Conversation

janosh
Copy link
Owner

@janosh janosh commented Jun 28, 2023

To make code base easier to navigate and understand. Thanks @ixxie for the suggestions. 馃憤

to make code base easier to navigate and understand
@janosh janosh added the pkg Package label Jun 28, 2023
@janosh janosh temporarily deployed to github-pages June 28, 2023 16:26 — with GitHub Actions Inactive
@ixxie
Copy link

ixxie commented Jun 28, 2023

Looks great and you are very welcome :)

ColorBar and ColorScaleSelect are charts right? You could add a charts module.

Consider renaming ptable to table or periodictable? Personally, I think its quite clear to import { PeriodicTable } from 'elementari/table.

@janosh janosh temporarily deployed to github-pages June 28, 2023 18:01 — with GitHub Actions Inactive
@janosh janosh force-pushed the split-lib-into-submodules branch from 6057519 to 5f1de0b Compare June 28, 2023 18:07
@janosh janosh temporarily deployed to github-pages June 28, 2023 18:08 — with GitHub Actions Inactive
@janosh janosh force-pushed the split-lib-into-submodules branch from 5f1de0b to 0d15781 Compare June 28, 2023 18:09
@janosh janosh merged commit d45b982 into main Jun 28, 2023
2 of 4 checks passed
@janosh janosh deleted the split-lib-into-submodules branch June 28, 2023 18:09
@janosh janosh temporarily deployed to github-pages June 28, 2023 18:11 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg Package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants