Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import of cached CSV is inconsistent #11

Closed
pbenner opened this issue Apr 27, 2023 · 1 comment · Fixed by #13
Closed

Import of cached CSV is inconsistent #11

pbenner opened this issue Apr 27, 2023 · 1 comment · Fixed by #13
Labels
bug Something isn't working

Comments

@pbenner
Copy link
Collaborator

pbenner commented Apr 27, 2023

Imported data frames from CSV differ between downloaded and cached version. To fix this issue, please add index = False to:

df.to_csv(cache_path)

@janosh
Copy link
Owner

janosh commented Apr 28, 2023

Thanks for noticing! Fix incoming.

@janosh janosh added the bug Something isn't working label Apr 28, 2023
janosh added a commit that referenced this issue Apr 28, 2023
…d Figshare downloads (#13)

* use load_train_test() to load wbm-summary in data.py (closes #10)

* fetch_process_wbm_dataset.py wrap urllib.request.urlretrieve in try/except (closes #12)

* add scripts/upload_to_figshare.py for publishing data files to figshare

* add data/figshare dir with readme and FIGSHARE in __init__.py

* change load_train_test() to load files from figshare instead of GitHub (closes #11)

* class Files issue warning when accessing a file path that doesn't exist

* docs recommend --depth 1 for git clone

* fix tests/test_data.py

* add auto-generated data/figshare/1.0.0.json

* pyproject.toml drop unused [tool.setuptools.package-data] matbench_discovery = ["data/mp/*.json"]

* fix AttributeError: 'DataFrame' object has no attribute 'material_id'
janosh added a commit that referenced this issue Jun 20, 2023
…d Figshare downloads (#13)

* use load_train_test() to load wbm-summary in data.py (closes #10)

* fetch_process_wbm_dataset.py wrap urllib.request.urlretrieve in try/except (closes #12)

* add scripts/upload_to_figshare.py for publishing data files to figshare

* add data/figshare dir with readme and FIGSHARE in __init__.py

* change load_train_test() to load files from figshare instead of GitHub (closes #11)

* class Files issue warning when accessing a file path that doesn't exist

* docs recommend --depth 1 for git clone

* fix tests/test_data.py

* add auto-generated data/figshare/1.0.0.json

* pyproject.toml drop unused [tool.setuptools.package-data] matbench_discovery = ["data/mp/*.json"]

* fix AttributeError: 'DataFrame' object has no attribute 'material_id'
janosh added a commit that referenced this issue Jun 20, 2023
…d Figshare downloads (#13)

* use load_train_test() to load wbm-summary in data.py (closes #10)

* fetch_process_wbm_dataset.py wrap urllib.request.urlretrieve in try/except (closes #12)

* add scripts/upload_to_figshare.py for publishing data files to figshare

* add data/figshare dir with readme and FIGSHARE in __init__.py

* change load_train_test() to load files from figshare instead of GitHub (closes #11)

* class Files issue warning when accessing a file path that doesn't exist

* docs recommend --depth 1 for git clone

* fix tests/test_data.py

* add auto-generated data/figshare/1.0.0.json

* pyproject.toml drop unused [tool.setuptools.package-data] matbench_discovery = ["data/mp/*.json"]

* fix AttributeError: 'DataFrame' object has no attribute 'material_id'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants