Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figshare json missing #16

Closed
pbenner opened this issue Apr 29, 2023 · 0 comments · Fixed by #19
Closed

Figshare json missing #16

pbenner opened this issue Apr 29, 2023 · 0 comments · Fixed by #19
Labels
bug Something isn't working pkg PyPI package related

Comments

@pbenner
Copy link
Collaborator

pbenner commented Apr 29, 2023

With a fresh conda environment and the cache cleaned, running fetch_process_wbm_dataset.py leads to the following error:

> python fetch_process_wbm_dataset.py 
Traceback (most recent call last):
  File "/home/pbenner/Source/tmp/matbench-discovery/data/wbm/fetch_process_wbm_dataset.py", line 24, in <module>
    from matbench_discovery.data import DATA_FILES
  File "/home/pbenner/.local/opt/anaconda3/envs/crysfeat/lib/python3.10/site-packages/matbench_discovery/data.py", line 27, in <module>
    f"{os.path.expanduser('~/.cache/matbench-discovery')}/{figshare_versions[-1]}",
IndexError: list index out of range

The error can be bypassed by copying figshare/1.0.0.json to [...]/site-packages/data/figshare.

Since this is matbench-discovery related data, I would suggest to use [...]/site-packages/data/matbench-discovery/figshare instead.
janosh added a commit that referenced this issue Apr 29, 2023
@janosh
pyproject add [tool.setuptools.package-data] ../data/figshare/* (closes
2978d36 
#16)

pyproject add optional-dependencies fetch-data
add url to install aviary from git
@janosh janosh mentioned this issue Apr 29, 2023
Merged
@janosh janosh added bug Something isn't working pkg PyPI package related labels Apr 29, 2023
janosh added a commit that referenced this issue Apr 30, 2023
@janosh
Run scripts in CI (#19)
0da443f 
* pyproject add [tool.setuptools.package-data] ../data/figshare/* (closes #16)

pyproject add optional-dependencies fetch-data
add url to install aviary from git

* add .github/workflows/run-scripts.yml to test a few scripts run error-free in CI

* make aviary optional in data/wbm/fetch_process_wbm_dataset.py

* add dep pymatviz

* run-scripts.yml continue-on-error: true

* i meant fail-fast: false

* editable install in run-scripts.yml

* install extra deps pymatviz[export-figs] to get kaleido

* add TMP_FIGS dir

looks like data/wbm/fetch_process_wbm_dataset.py might auto-cancelled due to exceeding the download limit or sth like that

just getting Error: The operation was canceled.
so let's test scripts/compile_metrics.py instead

* compile_metrics.py make dataframe_image optional

* run-scripts provide WANDB_API_KEY

* compile_metrics.py fix missing column access

* editable install in gh-pages.yml

* fix vite build ReferenceError: latest_figshare_release is not defined
janosh added a commit that referenced this issue Jun 20, 2023
@janosh
Run scripts in CI (#19)
67e9ede 
* pyproject add [tool.setuptools.package-data] ../data/figshare/* (closes #16)

pyproject add optional-dependencies fetch-data
add url to install aviary from git

* add .github/workflows/run-scripts.yml to test a few scripts run error-free in CI

* make aviary optional in data/wbm/fetch_process_wbm_dataset.py

* add dep pymatviz

* run-scripts.yml continue-on-error: true

* i meant fail-fast: false

* editable install in run-scripts.yml

* install extra deps pymatviz[export-figs] to get kaleido

* add TMP_FIGS dir

looks like data/wbm/fetch_process_wbm_dataset.py might auto-cancelled due to exceeding the download limit or sth like that

just getting Error: The operation was canceled.
so let's test scripts/compile_metrics.py instead

* compile_metrics.py make dataframe_image optional

* run-scripts provide WANDB_API_KEY

* compile_metrics.py fix missing column access

* editable install in gh-pages.yml

* fix vite build ReferenceError: latest_figshare_release is not defined
janosh added a commit that referenced this issue Jun 20, 2023
@janosh
Run scripts in CI (#19)
2dfb68e 
* pyproject add [tool.setuptools.package-data] ../data/figshare/* (closes #16)

pyproject add optional-dependencies fetch-data
add url to install aviary from git

* add .github/workflows/run-scripts.yml to test a few scripts run error-free in CI

* make aviary optional in data/wbm/fetch_process_wbm_dataset.py

* add dep pymatviz

* run-scripts.yml continue-on-error: true

* i meant fail-fast: false

* editable install in run-scripts.yml

* install extra deps pymatviz[export-figs] to get kaleido

* add TMP_FIGS dir

looks like data/wbm/fetch_process_wbm_dataset.py might auto-cancelled due to exceeding the download limit or sth like that

just getting Error: The operation was canceled.
so let's test scripts/compile_metrics.py instead

* compile_metrics.py make dataframe_image optional

* run-scripts provide WANDB_API_KEY

* compile_metrics.py fix missing column access

* editable install in gh-pages.yml

* fix vite build ReferenceError: latest_figshare_release is not defined
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working pkg PyPI package related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Run scripts in CI janosh/matbench-discovery
2 participants
@pbenner @janosh