Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HasError prop? #47

Closed
frederikhors opened this issue Feb 22, 2022 · 2 comments
Closed

HasError prop? #47

frederikhors opened this issue Feb 22, 2022 · 2 comments
Labels
awaiting user Needs more information from OP. enhancement New feature or request

Comments

@frederikhors
Copy link
Contributor

I think we need an hasError prop.

For the same reason we have an isLoading (or loading) one.
@janosh
Copy link
Owner

janosh commented Feb 27, 2022

Could you be a bit more specific here. The loading prop is controlled entirely externally.

I assume hasError should, by contrast, be handled by the component itself (i.e. if user tries to submit and required=true but selected is empty, hasError should automatically be set to true?) but also allow for external control?

@janosh janosh added awaiting user Needs more information from OP. enhancement New feature or request labels Feb 27, 2022
@janosh janosh closed this as completed in af009b5 Mar 6, 2022
@janosh
Copy link
Owner

janosh commented Mar 6, 2022

The new prop is now called invalid and documented in the readme. Thanks for this suggestion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
awaiting user Needs more information from OP. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@janosh @frederikhors