Export headings and desktop and add hide prop #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Export the array of headings - Export if desktop is active or not - Add option to disable visibility Knowing if Toc is in desktop mode enables me to change the layout according to that and change my layout to use the space without having to make extra calculations I want to hide Toc when there are less than 2 headlines. So the headlines are exported to be able to count them and a visible prop is added to be able to hide the Toc.
for more information, see https://pre-commit.ci
Change `visible` to `hide` since it feels more convenient
Amerlander
changed the title
|
Good additions all! 👍 Also thanks for describing all the use cases behind your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Knowing if Toc is in desktop mode enables me to change the layout according to that and change my layout to use the space without having to make extra calculations
I want to hide Toc when there are less than 2 headlines. So the headlines are exported to be able to count them and a hide prop is added to be able to hide the Toc.