Fix ToC preventing page scrolling beyond active heading when zoomed into page #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TocLi?.scrollIntoView() latter scrolls entire viewport, former only scrolls within ToC component also add props - activeTocLi: HTMLLIElement | null = null - tocItems: HTMLLIElement[] = [] rename prop activeTopOffset = 100 -> activeHeadingScrollOffset rename CSS var --toc-max-width -> --toc-desktop-max-width add CSS props - `aside.toc > nav > ul > li` - `border-radius: var(--toc-li-border-radius, 2pt)` - `padding: var(--toc-li-padding, 2pt 4pt)` - `aside.toc.mobile` - `bottom: var(--toc-mobile-bottom, 1em)` - `right: var(--toc-mobile-right, 1em)`
…eTocLi and CSS vars
|
@janosh yes, that solving a problem 👍 |
Does this PR also address your 2nd problem? I couldn't reproduce that one. |
Yes, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22.
@oskar-gmerek Could you try the code in this branch (e.g. by copy-pasting the
Toc.sveltecomponent into yournode_modules) to see if it solves the first problem reported in #22.