Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new electrs error message when an address has a history longer than the configured lookup limit #494

Merged
merged 3 commits into from
Mar 24, 2023
Merged

Use new electrs error message when an address has a history longer than the configured lookup limit #494

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6278558
add missing '.message'
ExperiBass Dec 25, 2022
4e91c70
add missing deps
ExperiBass Dec 25, 2022
f1f43ec
update the electrs tx limit error message
ExperiBass Dec 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion views/address.pug
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ block content
else if (addressDetailsErrors && addressDetailsErrors.length > 0)
+contentSection
each err, errIndex in addressDetailsErrors
if (err.e && err.e && err.e.message == "history too large")
if (err.e && err.e.message && err.e.message == "history too large")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part is wrong (the check for err.e.message already exists).

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, misread. This looks right.

span Failed to retrieve transaction history from ElectrumX because this address is involved in too many transactions (more than ElectrumX currently supports retrieving). See
a(href="https://github.com/janoside/btc-rpc-explorer/issues/67") Issue #67
span for more information.
Expand Down