-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace OpenCV with GPU blob detection #28
Open
osnr
wants to merge
12
commits into
master
Choose a base branch
from
osnr-regl-detect
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can pick up dots with sigma = 12. Not fully plugged in yet. Sigma changing also broken right now.
This seems to basically work.
Use canvas for all remaining rendering.
Amazing. As discussed in person, going to bring this in a bit more incrementally, and next to the OpenCV implementation for now (since this is still less robust). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increases fps 3-4x (depending on dot size) and makes page load times way faster.
https://www.youtube.com/watch?v=7D3wY_wMGLo
Uses Laplacian of Gaussian at fixed scale to find dots; video data never needs to touch the CPU now.
todos
needs some extra docs on what sigma and dotThreshold mean
should probably fix up outCanvas so it's not just hanging out there
would like to test on different cameras than 1080p, cc @ajbouh
other optimization ideas: