Skip to content

Commit

Permalink
Fix a remaining issue with b8c8871 (#20) (#25)
Browse files Browse the repository at this point in the history
It turns out my original proposal for #20 was correct, but not for the
reasons I thought. We need to set both `background-color` and `color` to
`initial` on `div.highlight pre` because that's where Chroma sets those
colors (including the default `color` if configured). Setting to
`initial` there makes it so that if the selected style *doesn't*
configure a default color, we'll use the `initial` color, which is going
to be the right choice because the reason style author left that unset
because they didn't consider dark color schemes messing with their
style. Then we `unset` the colors on `div.highlight code` because
otherwise the `code` colors from the theme will override the colors that
would otherwise be inherited from Chroma's `<pre>` element.

Stricly speaking I can't say that setting `background-color` to
`initial` is required, because I haven't found a Chroma style that
*doesn't* set a `background-color`, but I figure it's possible (at least
for a light theme) and it makes sense to fix it just in case, and causes
no harm otherwise.
  • Loading branch information
ajorg committed Aug 13, 2021
1 parent 78c5241 commit 2fa45b9
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion layouts/partials/style.html
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,14 @@
font-size: 14px;
}

div.highlight pre {
background-color: initial;
color: initial;
}

div.highlight code {
background-color: unset;
color: initial;
color: unset;
}

blockquote {
Expand Down

0 comments on commit 2fa45b9

Please sign in to comment.