Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Setting for max results #142

Closed
s-kocher opened this issue Mar 7, 2019 · 4 comments
Closed

[Feature] Setting for max results #142

s-kocher opened this issue Mar 7, 2019 · 4 comments

Comments

@s-kocher
Copy link

s-kocher commented Mar 7, 2019

Hello,
thanks for this very useful extension ! The number of matches seems limited to 10 results, it will be nice to be able to choose a greater number from settings window (or no limit with a scrollable popup ?).

Regarding this maximum number of matchs, when enabling the all windows search, are the matches prioritized for the current window ?

@janraasch
Copy link
Owner

Hi there, thank you for your interest and your kind words 😊.

The shown number of matches is limit to 10. That is correct.

It would be technically possible to implement a feature to make this limitconfigurable via the settings window. However I am wondering about the use case, because usually when a user is searching for a tab she would probably want the tab to show up very high in the list, so she can easily click it. Instead of looking at all the results, she would probably just type more characters into the input field to make the search more specific.

What use case do you have in mind, where you would need more than 10 results and you would rather have that, than simply improve the search result set?

Regarding this maximum number of matchs, when enabling the all windows search, are the matches prioritized for the current window ?

The prioritization is only with respect to how good the tab url and title match the search term entered by the user.

@s-kocher
Copy link
Author

The use case is when I search something without accurate information, for example I have a lot of youtube tabs opened on different windows and want to see all youtube (so "youtube" or other domain is my search input) tabs aggregated in tab ahead search results to find some duplicate or something inspiring me to see / listen.

@janraasch
Copy link
Owner

Hi @s-kocher, okay. To me this sounds more like you are browsing rather than actively searching for something specific, while the latter is the main use case of this extension.

I think there are other extensions out there which cover your use case, like e.g. Quick Tabs. Please also have a look at some of the other alternatives I listed on the README.

That being said, this feature

The number of matches seems limited to 10 results, it will be nice to be able to choose a greater number from settings window

is technically quite easy to add. Here's #143 a working version. Qualitywise there are still a lot of edge cases to consider, see TODOs in #143, however you can take this for a spin, if you like: You can download the TabAhead.zip file from https://github.com/janraasch/tab-ahead/releases/tag/v1.4.0-alpha1, then unzip it, and under chrome://extensions/ enable Developer mode to be able to Load unpacked extension.... The keyboard shortcut can be configured on the chrome://extensions/ page as well.

@janraasch
Copy link
Owner

No action in about a year. #stale

Hence I'll close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants