Topic/add social login example #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 8, 2015 15:53
Also improved the node token url example and simplified README.
| 1. `cd Janrain-Sample-Code/widget-examples` | ||
| 1. `npm install` | ||
| 1. Edit line 7 of `server.js`, replacing `_API_KEY_` with your Janrain API key. | ||
| 1. Edit line 1 of `application_domain.js`, replacing `_APPLICATION_DOMAIN_` with |
There was a problem hiding this comment.
These instructions worked for me, but I worry that later on, someone will change the code and will forget to update the line numbers here. Do you think we need the line numbers?
There was a problem hiding this comment.
Hmm, that's a good point. I'm ok with either, I just thought extra specificity couldn't hurt. @Jp-Janrain @samanthajanrain @kris-janrain thoughts?
There was a problem hiding this comment.
Yes, you could instead say something like "in server.js, replace _API_KEY_ with your Janrain API key." Line numbers may change.
|
@tcmitche: Looks good to me. |
tcmitche
added a commit
that referenced
this pull request
Oct 20, 2015
Topic/add social login example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.