DIP-205 log exception if DEBUG=True

janrain · Apr 12, 2016 · dfb3bd8 · dfb3bd8
1 parent 1400293
commit dfb3bd8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/bluekai/job.py b/bluekai/job.py
@@ -16,6 +16,8 @@ def run(job, writter, config, logger, datalib, converter):
 
         err = str(ex)
         logger.error(err)
+        if config['DEBUG']:
+            logger.exception(ex)
 
     finally:
         if err:

diff --git a/tests/test_job.py b/tests/test_job.py
@@ -36,9 +36,11 @@ def test_with_errors(self, do_job_mock):
         error = "test_error"
         exception = Exception(error)
         do_job_mock.side_effect = exception
+        self.config['DEBUG'] = True
         run(self.job_mock, self.writter_mock, self.config, self.logger_mock, self.datalib_mock, self.converter_mock)
         self.job_mock.stop.assert_called_once_with()
         self.logger_mock.error.assert_called_with(str(exception))
+        self.logger_mock.exception.assert_called_with(exception)
         self.logger_mock.error.assert_called_with(error)
         self.logger_mock.info.assert_has_calls([ call("start"), call("end (1 seconds)") ])