Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JANRAIN-6883 Changed cron job to hit /export instead of /sync #26

Merged
merged 1 commit into from
Jan 23, 2018
Merged

JANRAIN-6883 Changed cron job to hit /export instead of /sync #26

merged 1 commit into from
Jan 23, 2018

Conversation

akameron
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 2ba78ea on JANRAIN-6883/fix-cron-configuration into 7aa1e65 on master.

Rtowne-Janrain
Rtowne-Janrain reviewed Jan 19, 2018
View reviewed changes
Copy link

@Rtowne-Janrain Rtowne-Janrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have to do anything to delete the previous cron that may've already been deployed?

BCox-Janrain
BCox-Janrain reviewed Jan 23, 2018
View reviewed changes
Copy link
Contributor

@BCox-Janrain BCox-Janrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to export every minute? Also, we're no longer syncing to bluekai?

BCox-Janrain
BCox-Janrain approved these changes Jan 23, 2018
View reviewed changes
Copy link
Contributor

@BCox-Janrain BCox-Janrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mixed this up with other services. I remember this now. 👍

@akameron akameron merged commit 8196a7c into master Jan 23, 2018
@akameron akameron deleted the JANRAIN-6883/fix-cron-configuration branch January 23, 2018 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rtowne-Janrain Rtowne-Janrain Rtowne-Janrain approved these changes

@BCox-Janrain BCox-Janrain BCox-Janrain approved these changes

@thea-janrain thea-janrain thea-janrain approved these changes

@pearcedavis pearcedavis pearcedavis approved these changes

@Jp-Janrain Jp-Janrain Awaiting requested review from Jp-Janrain

@jack-janrain jack-janrain Awaiting requested review from jack-janrain

@ebeesonjanrain ebeesonjanrain Awaiting requested review from ebeesonjanrain

@tcmitche tcmitche Awaiting requested review from tcmitche

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@akameron @coveralls @BCox-Janrain @thea-janrain @pearcedavis @Rtowne-Janrain