Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parallel processing of audio tracks #243

Closed
Borewit opened this issue Jul 20, 2018 · 0 comments
Closed

Parallel processing of audio tracks #243

Borewit opened this issue Jul 20, 2018 · 0 comments

Comments

@Borewit
Copy link
Contributor

Borewit commented Jul 20, 2018

Avoid parallel processing of audio tracks

Calling async file I/O functions in a loop is not a good idea:

mediacenterjs/lib/media-handler.js

Line 50 in 86d99ba

_.each(files, function(file) {

This can cause:

  • Out of memory exceptions
  • To many file handlers open
  • Performance issue

I suggest to to this in a serial fashion.
@Borewit Borewit mentioned this issue Jul 20, 2018
Merged
jansmolders86 added a commit that referenced this issue Jul 20, 2018
@jansmolders86
Merge pull request #245 from Borewit/improve-audio-support
fcbd09b 
#243 Serial processing of audio tracks, fix the progress counter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jansmolders86 @Borewit