Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack 4 compat #108

Closed
dweber019 opened this issue Feb 27, 2018 · 6 comments
Closed

Webpack 4 compat #108

dweber019 opened this issue Feb 27, 2018 · 6 comments

Comments

@dweber019
Copy link

Please update the plugin to work with webpack 4.
Thx

@jantimon jantimon closed this as completed Mar 1, 2018
@jantimon jantimon reopened this Mar 1, 2018
@hlehmann
Copy link

hlehmann commented Mar 2, 2018

This is the error I get:

Error: Plugin could not be registered at 'html-webpack-plugin-before-html-processing'. Hook was not found.
BREAKING CHANGE: There need to exist a hook at 'this.hooks'. To create a compatiblity layer for this hook, hook into 'this._pluginCompat'.
    at Compilation.plugin (node_modules/tapable/lib/Tapable.js:63:9)
    at Compilation.deprecated [as plugin] (internal/util.js:53:15)
    at node_modules/favicons-webpack-plugin/index.js:57:19

@gorbypark
Copy link

gorbypark commented Mar 4, 2018

I get this error with webpack 4:
✖ 「wdm」: Error: Module build failed: TypeError: Cannot read property 'context' of undefined at Object.module.exports (/Users/xxxxxx/Documents/Code/xxxxx/node_modules/favicons-webpack-plugin/lib/favicons.js:15:44)

@brunocodutra
Copy link
Collaborator

Meanwhile you could try webapp-webpack-plugin which I originally forked from favicons-webpack-plugin to add some missing functionality, including support for Webpack 4.

et added a commit to seedom-io/seedom-web3 that referenced this issue Mar 13, 2018
The favicons plugin was never updated for v4: jantimon/favicons-webpack-plugin#108
Hence the switch to webapp-webpack-plugin
@jantimon
Copy link
Owner

Released 0.0.8

@skizzo
Copy link

skizzo commented Mar 11, 2019

Still not working.

@Chanaeva
Copy link

Chanaeva commented May 9, 2019

Doesn't seem to be working? Error: Module build failed (from ./node_modules/favicons-webpack-plugin/lib/favicons.js):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants