-
-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update favicons to 7.0.0 #291
Conversation
@jantimon may you enable CI to check this PR? |
Thanks for the upgrade - i'll try to release it as an beta in the next days |
thanks for the pr @andy128k, i'm using your fork without any issues would be great to get this released as a beta 👍 just had to change the peerDependencies to allow for the beta "peerDependencies": {
"webpack": "^5.0.0",
"favicons": ">= 6.2.0 || ^7.0.0-beta.1"
},
|
@carlhopf I've cherry-picked your commit and added to this PR. |
@jantimon gentle bump |
😬 |
Hey. Are there any chances this PR will be merged? ❤️ |
The latest favicons use As a temporary workaround one can do this under favicons option:
IMO a more proper fix for this should also be included in this PR? |
Hi there! Any news? |
Hi there! Any news? |
Not to pile on, but we need The older |
I see that a PR to fix this issue has been merged. Do we know when the next release will be, though? |
Just opened an issue requesting a new release |
There is an intention to release favicons 7.0.0 soon. This PR is created to ensure that the upcoming release doesn't break downstream too much.