Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update favicons to 7.0.0 #291

Merged
merged 1 commit into from
Sep 29, 2022
Merged

Update favicons to 7.0.0 #291

merged 1 commit into from
Sep 29, 2022

Conversation

andy128k
Copy link
Collaborator

@andy128k andy128k commented Nov 13, 2021

There is an intention to release favicons 7.0.0 soon. This PR is created to ensure that the upcoming release doesn't break downstream too much.

@andy128k andy128k marked this pull request as ready for review November 13, 2021 13:35
@andy128k
Copy link
Collaborator Author

@jantimon may you enable CI to check this PR?

@jantimon
Copy link
Owner

Thanks for the upgrade - i'll try to release it as an beta in the next days

@carlhopf
Copy link
Contributor

thanks for the pr @andy128k, i'm using your fork without any issues

would be great to get this released as a beta 👍

just had to change the peerDependencies to allow for the beta

  "peerDependencies": {
    "webpack": "^5.0.0",
    "favicons": ">= 6.2.0 || ^7.0.0-beta.1"
  },

@andy128k
Copy link
Collaborator Author

@carlhopf I've cherry-picked your commit and added to this PR.

@andy128k
Copy link
Collaborator Author

@jantimon gentle bump

@MikeSha
Copy link

MikeSha commented Apr 6, 2022

😬

@MikeSha
Copy link

MikeSha commented Jun 1, 2022

Hey. Are there any chances this PR will be merged? ❤️

@OctoNezd
Copy link

OctoNezd commented Sep 6, 2022

The latest favicons use manifest.webmanifest, instead of manifest.json, resulting in manifest option of favicons-webpack-plugin being ignored.

As a temporary workaround one can do this under favicons option:

                files: {
                    android: {
                        manifestFileName: "manifest.json",
                    },
                },

IMO a more proper fix for this should also be included in this PR?

@andy128k andy128k changed the title Update favicons to 7.0.0-beta.x Update favicons to 7.0.0 Sep 11, 2022
@n-rodriguez
Copy link

Hi there! Any news?

@n-rodriguez
Copy link

Hi there! Any news?

@Jarch09
Copy link

Jarch09 commented Sep 29, 2022

Not to pile on, but we need favicons upgraded >= 7.0.0.

The older favicons version (^6) currently being referenced has security vulnerabilities.

@andy128k andy128k merged commit dcde51f into jantimon:main Sep 29, 2022
@andy128k andy128k deleted the favicons-7.0.0 branch September 29, 2022 13:35
@cmloegcmluin
Copy link

I see that a PR to fix this issue has been merged. Do we know when the next release will be, though?

@Jarch09
Copy link

Jarch09 commented Sep 30, 2022

Just opened an issue requesting a new release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants