Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(examples): throw right when test fails instead of wait for timeout #1751

Merged
merged 1 commit into from
Jun 10, 2023

Conversation

SevenOutman
Copy link
Contributor

@SevenOutman SevenOutman commented May 21, 2022

Speed up tests by calling done(err) to fail a test when assertion fails, instead of waiting for timeout.

@alexander-akait alexander-akait merged commit 0caa0fe into jantimon:main Jun 10, 2023
@SevenOutman SevenOutman deleted the improve-test-timeout branch June 12, 2023 05:45
@SevenOutman
Copy link
Contributor Author

Hi @alexander-akait, happy to see this project getting maintenance again! Would you please look into #1752 sometime?

@alexander-akait
Copy link
Collaborator

@SevenOutman yeah, I will look soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants