Passing true to minify does nothing #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All `html-minifier` options are `false` by default, so passing just true does nothing to the output
| // If `options.minify` is set to true use the default minify options | ||
| var minifyOptions = _.isObject(this.options.minify) ? this.options.minify : {}; | ||
| html = minify(html, minifyOptions); | ||
| html = minify(html, this.options.minify); |
There was a problem hiding this comment.
IDK if this change is necessary, as it might break someone's stuff. Passing in an empty object if it was just true before did nothing to the output though, so I'm guessing people using the minify-option do pass an object
jantimon
added a commit
that referenced
this pull request
Aug 15, 2015
Passing true to minify does nothing
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All
html-minifieroptions arefalseby default, so passing just true does nothing to the output