Skip to content

Commit

Permalink
Merge pull request #533 from robpickerill/ec2-eips
Browse files Browse the repository at this point in the history
update quota names for EIPs
  • Loading branch information
jantman committed Jul 8, 2021
2 parents 265454e + f32de23 commit 8218473
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions awslimitchecker/services/ec2.py
Original file line number Diff line number Diff line change
Expand Up @@ -756,7 +756,7 @@ def _get_limits_networking(self):
limit_type='AWS::EC2::EIP',
limit_subtype='AWS::EC2::VPC',
ta_service_name='VPC', # TA shows this as VPC not EC2
quotas_name='Number of EIPs - VPC EIPs'
quotas_name='EC2-VPC Elastic IPs'
)
# the EC2 limits screen calls this 'EC2-Classic Elastic IPs'
# but Trusted Advisor just calls it 'Elastic IP addresses (EIPs)'
Expand All @@ -767,7 +767,7 @@ def _get_limits_networking(self):
self.warning_threshold,
self.critical_threshold,
limit_type='AWS::EC2::EIP',
quotas_name='Elastic IP addresses for EC2-Classic'
quotas_name='EC2-Classic Elastic IPs'
)
limits['VPC security groups per elastic network interface'] = AwsLimit(
'VPC security groups per elastic network interface',
Expand Down
4 changes: 2 additions & 2 deletions awslimitchecker/tests/services/test_ec2.py
Original file line number Diff line number Diff line change
Expand Up @@ -895,7 +895,7 @@ def test_simple(self):
].quotas_service_code == 'ec2'
assert limits[
'VPC Elastic IP addresses (EIPs)'
].quota_name == 'Number of EIPs - VPC EIPs'
].quota_name == 'EC2-VPC Elastic IPs'
assert limits[
'VPC Elastic IP addresses (EIPs)'
].quotas_unit == 'None'
Expand All @@ -904,7 +904,7 @@ def test_simple(self):
].quotas_service_code == 'ec2'
assert limits[
'Elastic IP addresses (EIPs)'
].quota_name == 'Elastic IP addresses for EC2-Classic'
].quota_name == 'EC2-Classic Elastic IPs'
assert limits[
'Elastic IP addresses (EIPs)'
].quotas_unit == 'None'
Expand Down

0 comments on commit 8218473

Please sign in to comment.