Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to describe virtual private gateways #302

Merged
merged 6 commits into from Sep 21, 2017

Conversation

andrewmichael
Copy link
Contributor

Before submitting pull requests, please see the
Development documentation
and specifically the Pull Request Guidelines.

IMPORTANT: Please take note of the below checklist, especially the first two items.

Pull Request Checklist

  • All pull requests should be against the develop branch, not master.
  • All pull requests must include the Contributor License Agreement (see below).
  • Code should conform to the Development Guidelines:
    • pep8 compliant with some exceptions (see pytest.ini)
    • 100% test coverage with pytest (with valid tests). If you have difficulty
      writing tests for the code, feel free to ask for help or submit the PR without tests.
    • Complete, correctly-formatted documentation for all classes, functions and methods.
    • documentation has been rebuilt with tox -e docs
    • Connections to the AWS services should only be made by the class's
      connect() and connect_resource() methods, inherited from
      awslimitchecker.connectable.Connectable
    • All modules should have (and use) module-level loggers.
    • Commit messages should be meaningful, and reference the Issue number
      if you're working on a GitHub issue (i.e. "issue #x - "). Please
      refrain from using the "fixes #x" notation unless you are sure that the
      the issue is fixed in that commit.
    • Git history is fully intact; please do not squash or rewrite history.

Contributor License Agreement

By submitting this work for inclusion in awslimitchecker, I agree to the following terms:

  • The contribution included in this request (and any subsequent revisions or versions of it)
    is being made under the same license as the awslimitchecker project (the Affero GPL v3,
    or any subsequent version of that license if adopted by awslimitchecker).
  • My contribution may perpetually be included in and distributed with awslimitchecker; submitting
    this pull request grants a perpetual, global, unlimited license for it to be used and distributed
    under the terms of awslimitchecker's license.
  • I have the legal power and rights to agree to these terms.

@codecov-io
Copy link

codecov-io commented Sep 21, 2017

Codecov Report

Merging #302 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           develop   #302   +/-   ##
======================================
  Coverage      100%   100%           
======================================
  Files           25     25           
  Lines         1896   1901    +5     
  Branches       293    293           
======================================
+ Hits          1896   1901    +5
Impacted Files Coverage Δ
awslimitchecker/services/vpc.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1db709a...abf7a35. Read the comment docs.

@jantman
Copy link
Owner

jantman commented Sep 21, 2017

@andrewmichael This looks great, thanks so much! I should be merging it sometime in the next 24 or 48 hours, and then cutting the 1.0.0 release.

@jantman jantman added the ready label Sep 21, 2017
@jantman jantman added this to the 1.0.0 milestone Sep 21, 2017
@jantman
Copy link
Owner

jantman commented Sep 21, 2017

Integration tests passed on latest commit.

@jantman jantman merged commit 58f9edc into jantman:develop Sep 21, 2017
@jantman jantman removed the ready label Sep 21, 2017
@jantman
Copy link
Owner

jantman commented Sep 21, 2017

Thanks so much, @andrewmichael ! Hopefully a release will be coming out in the next day or two.

jantman added a commit that referenced this pull request Sep 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants