Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #557 - added support to cognito user pool limit #558

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

luchees
Copy link

@luchees luchees commented Aug 23, 2021

Summary

adds support for Cognito service, user pool limits

Pull Request Checklist

  • All pull requests should be against the develop branch, not master.
  • All pull requests must include the Contributor License Agreement (see below).
  • Whether or not your PR includes unit tests:
    • Please make sure you have run the exact code contained in the PR locally, and it functions as desired.
    • Please make sure the TravisCI build passes or, if not, you've corrected any obvious problems identified by the tests.
  • Code should conform to the Development Guidelines:
    • pep8 compliant with some exceptions (see pytest.ini)
    • 100% test coverage with pytest (with valid tests). If you have difficulty
      writing tests for the code, that's fine, just mention that in the summary and either
      ask for assistance, or clarify that you'd like someone else to handle the tests. PRs that
      include complete test coverage will usually be merged faster.
    • Complete, correctly-formatted documentation for all classes, functions and methods.
    • documentation has been rebuilt with tox -e docs
    • Connections to the AWS services should only be made by the class's
      connect() and connect_resource() methods, inherited from
      awslimitchecker.connectable.Connectable
    • All modules should have (and use) module-level loggers.
    • Commit messages should be meaningful, and reference the Issue number
      if you're working on a GitHub issue (i.e. "issue #x - "). Please
      refrain from using the "fixes #x" notation unless you are sure that the
      the issue is fixed in that commit.
    • Git history is fully intact; please do not squash or rewrite history.

Contributor License Agreement

By submitting this work for inclusion in awslimitchecker, I agree to the following terms:

  • The contribution included in this request (and any subsequent revisions or versions of it)
    is being made under the same license as the awslimitchecker project (the Affero GPL v3,
    or any subsequent version of that license if adopted by awslimitchecker).
  • My contribution may perpetually be included in and distributed with awslimitchecker; submitting
    this pull request grants a perpetual, global, unlimited license for it to be used and distributed
    under the terms of awslimitchecker's license.
  • I have the legal power and rights to agree to these terms.

@luchees
Copy link
Author

luchees commented Aug 23, 2021

The doc build is failing, not sure how to proceed.
https://app.travis-ci.com/github/jantman/awslimitchecker/jobs/533144653

Copy link
Owner

@jantman jantman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luchees Thanks so much for this. I've only glanced over the code so far, but it looks good to me aside from one comment I made.

You can ignore the docs build failure, I'll fix that in the develop branch. It appears that TravisCI changed their URL structure, and the old URL to the build is now 404.

awslimitchecker/services/cognito.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2021

Codecov Report

Merging #558 (9ccaef7) into develop (eec67df) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop      #558   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           44        45    +1     
  Lines         3294      3322   +28     
  Branches       485       487    +2     
=========================================
+ Hits          3294      3322   +28     
Impacted Files Coverage Δ
awslimitchecker/services/__init__.py 100.00% <100.00%> (ø)
awslimitchecker/services/cognito.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eec67df...9ccaef7. Read the comment docs.

@luchees
Copy link
Author

luchees commented Aug 24, 2021

@jantman Thanks for the comment I indeed looked over that unused function. Removed it.

Now I got the hang of the setup and will try to implement more use cases I have.
Thanks for this project, been a lifesaver for me!

@luchees luchees requested a review from jantman August 24, 2021 09:14
@luchees
Copy link
Author

luchees commented Sep 7, 2021

@jantman Hello, is it possible to merge this PR?
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants