Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to ignore OFX transaction #183

Closed
jantman opened this issue Mar 4, 2018 · 2 comments
Closed

Option to ignore OFX transaction #183

jantman opened this issue Mar 4, 2018 · 2 comments
Assignees
Milestone

Comments

@jantman
Copy link
Owner

jantman commented Mar 4, 2018

On the OFX Reconcile screen, for OFX transactions, there should be an option to ignore specific transactions. This is especially for $0 OFX transactions that certain banks sometimes post, but we don't want to have to create a matching Transaction for.

We should also exclude OFXTransactions that match the Account's interest/payment/fee regexes. When doing this, either use/update OFXTransaction's is_ fields or remove them.

@jantman jantman added this to the 0.8.0 milestone Mar 4, 2018
jantman added a commit that referenced this issue Mar 8, 2018
@jantman
Copy link
Owner Author

jantman commented Mar 8, 2018

Ok, in 4ffa682 I have the first part of this, implementing the "ignore" link for OFXTransactions, the same way the "no OFX" link works for Transactions.

The second part of this is a way to automatically mark some OFXTransactions as not needing to be reconciled. We have a partial implementation of this already, namely the is_payment, is_late_fee, is_interest_charge, is_other_fee and is_interest_payment fields on OFXTransaction, and then the re_interest_charge, re_interest_paid, re_payment and re_fee fields on Account. None of these have been used yet. The Account fields are populated with default values in the DB, but are not currently exposed in the UI.

So, what I think remains:

  • Expose the re_* Account fields in the Account editing modal and handle them for add/edit. Allow them to be null.
  • Round-trip test for those changes to the Account modal.
  • Add non-default values for them to at least one Account instance in sampledata
  • Add a DB event handler to the OFXTransaction model that sets all of the is_* fields according to the Account's regexes. This should only look at regexes that are non-None and non-empty. All is_* fields should be cleared and then reset in the handler. This should be a standalone function or else a method on the OFXTransaction model itself.
  • Add verification of that behavior to some of the existing Transaction tests. Be sure to comment what it's relying on, and where the data is set.
  • Add a command-line script and entrypoint to regenerate ALL of the OFXTransaction is_* fields according to the above. Test it manually.
  • In OFXTransaction.unreconciled(), exclude any that have any of their is_* fields set to True.
  • Acceptance tests for the previous.

jantman added a commit that referenced this issue Mar 8, 2018
jantman added a commit that referenced this issue Mar 8, 2018
…6, to fix failing acceptance tests caused by Ubuntu upgrade from Chrome 64 to 65
jantman added a commit that referenced this issue Mar 9, 2018
jantman added a commit that referenced this issue Mar 9, 2018
…Paid, Payment, Late Fee, and Other Fee regexes on each account
jantman added a commit that referenced this issue Mar 9, 2018
jantman added a commit that referenced this issue Mar 9, 2018
…o set is_* fields according to Account re_* fields
jantman added a commit that referenced this issue Mar 9, 2018
…ields, that triggers 'OFXTransaction.update_is_fields()' to recalculate using the new regex
jantman added a commit that referenced this issue Mar 9, 2018
jantman added a commit that referenced this issue Mar 9, 2018
jantman added a commit that referenced this issue Mar 9, 2018
@jantman jantman self-assigned this Mar 9, 2018
@jantman jantman closed this as completed in 53eafca Mar 9, 2018
jantman added a commit that referenced this issue Mar 9, 2018
Fixes #183 - UI to ignore OFXTransactions, and ignore is_ OFXTransactions
@jantman jantman reopened this Mar 9, 2018
@jantman
Copy link
Owner Author

jantman commented Jul 7, 2018

Released today in 1.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant