Skip to content

Commit

Permalink
feat: switch defaults of the --embed-as-dependencies and in-place
Browse files Browse the repository at this point in the history
… options. (#1787)

* feat: switch defaults of the `--embed-as-dependencies` and `in-place` options.

Signed-off-by: David Festal <dfestal@redhat.com>

* chore: update dirty yarn.lock

Signed-off-by: David Festal <dfestal@redhat.com>

---------

Signed-off-by: David Festal <dfestal@redhat.com>
  • Loading branch information
davidfestal committed Jun 5, 2024
1 parent e565202 commit 049e675
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 18 deletions.
12 changes: 6 additions & 6 deletions packages/cli/src/commands/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -123,16 +123,16 @@ export function registerScriptCommand(program: Command) {
)
.option(
'--embed-as-dependencies',
'Include embedded packages as private dependencies of backend plugins, instead of merging them with the generated code. Experimental for now, but expected to become the default.',
false,
'Include embedded packages as private dependencies of backend plugins. When value is `false` (using `--no-embed-as-dependencies`), source code of embedded plugins is merged with the generated code, so that the embedded plugin packages are completly erased (only available for legacy reasons: use with care).',
true,
)
.option('--no-embed-as-dependencies', undefined, true)
.option('--no-embed-as-dependencies', undefined, false)
.option(
'--in-place',
'Adds the frontend dynamic plugin assets to the `dist-scalprum` folder of the original plugin package. When value is `false` (using `--no-in-place`), it produces the assets in a distinct package located in the `dist-dynamic` sub-folder, as for backend plugins. `true` by default for now, it is expected to become `false` by default.',
true,
'Adds the frontend dynamic plugin assets to the `dist-scalprum` folder of the original plugin package, instead of producing the assets in a distinct package located in the `dist-dynamic` sub-folder, as for backend plugins.',
false,
)
.option('--no-in-place', undefined, false)
.option('--no-in-place', undefined, true)
.option(
'--scalprum-config <file>',
'Allows retrieving scalprum configuration from an external JSON file, instead of using a `scalprum` field of the `package.json`. Frontend plugins only.',
Expand Down
12 changes: 0 additions & 12 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -6307,18 +6307,6 @@
yml-loader "^2.1.0"
yn "^4.0.0"

"@janus-idp/shared-react@2.6.3":
version "2.6.3"
resolved "https://registry.npmjs.org/@janus-idp/shared-react/-/shared-react-2.6.3.tgz#de98b434d19b96197f053095e0c412e3eabc1155"
integrity sha512-kQzY4+WXTtArAy9breW7PuWonlT6GbgZEEA+oClkOY5ETl9AW7QKgymNHSdemkIZrx+qJro/xF2yt70skIrBdg==
dependencies:
"@kubernetes/client-node" "^0.20.0"
classnames "^2.3.2"
date-fns "^2.30.0"
file-saver "^2.0.5"
lodash "^4.17.21"
mathjs "^11.11.2"

"@jest/console@^29.7.0":
version "29.7.0"
resolved "https://registry.yarnpkg.com/@jest/console/-/console-29.7.0.tgz#cd4822dbdb84529265c5a2bdb529a3c9cc950ffc"
Expand Down

0 comments on commit 049e675

Please sign in to comment.