fix(quay): Format date, size and Manifest information to be same as on the quay UI #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tumido
requested changes
Feb 8, 2023
|
I execute prettier, now should be ok, can you PTAL |
tumido
reviewed
Feb 9, 2023
| } | ||
|
|
||
| const i = Math.floor(Math.log(sizeInBytes) / Math.log(1024)); | ||
| return `${Number((sizeInBytes / Math.pow(1024, i)).toFixed(2)) * 1} ${ |
There was a problem hiding this comment.
Hm, can you explain me what is the * 1 magic about? I'm unable to find a functional difference.
return `${Number((sizeInBytes / Math.pow(1024, i)).toFixed(2)) * 1} ${
^^^^|
|
||
| const i = Math.floor(Math.log(sizeInBytes) / Math.log(1024)); | ||
| return `${Number((sizeInBytes / Math.pow(1024, i)).toFixed(2)) * 1} ${ | ||
| ['B', 'kB', 'MB', 'GB', 'TB'][i] |
There was a problem hiding this comment.
Wouldn't it be better if this array was a global constant? I may be too picky here, just a nit.
Comment on lines
+3
to
+18
| export function getSeverityColor(severity: VulnerabilitySeverity) { | ||
| switch (severity) { | ||
| case VulnerabilitySeverity.Critical: | ||
| return '#7D1007'; | ||
| case VulnerabilitySeverity.High: | ||
| return '#C9190B'; | ||
| case VulnerabilitySeverity.Medium: | ||
| return '#EC7A08'; | ||
| case VulnerabilitySeverity.Low: | ||
| return '#F0AB00'; | ||
| case VulnerabilitySeverity.None: | ||
| return '#3E8635'; | ||
| default: | ||
| return '#8A8D90'; | ||
| } | ||
| } |
There was a problem hiding this comment.
I think a constant would be nice here, but I may be too picky:
Suggested change
| export function getSeverityColor(severity: VulnerabilitySeverity) { | |
| switch (severity) { | |
| case VulnerabilitySeverity.Critical: | |
| return '#7D1007'; | |
| case VulnerabilitySeverity.High: | |
| return '#C9190B'; | |
| case VulnerabilitySeverity.Medium: | |
| return '#EC7A08'; | |
| case VulnerabilitySeverity.Low: | |
| return '#F0AB00'; | |
| case VulnerabilitySeverity.None: | |
| return '#3E8635'; | |
| default: | |
| return '#8A8D90'; | |
| } | |
| } | |
| export function getSeverityColor(severity: VulnerabilitySeverity) { | |
| export const SEVERITY_COLORS = new Proxy( | |
| { | |
| VulnerabilitySeverity.Critical: '#7D1007', | |
| VulnerabilitySeverity.High: '#C9190B', | |
| VulnerabilitySeverity.Medium: '#EC7A08', | |
| VulnerabilitySeverity.Low: '#F0AB00', | |
| VulnerabilitySeverity.None: '#3E8635' | |
| }, | |
| { | |
| get: (o, k) => k in o ? o[k] : '#8A8D90' | |
| } | |
| ) |
This should be easily addressable via SEVERITY_COLORS[severity].
Again, just a nit, if you don't think agree, feel free to leave as it is, your implementation is completely reasonable and understandable.
1 task
tumido
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#100
Format date, size and Manifest information to be same as on the quay UI