Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[e2e-tests] Add security scan check to quay plugin suite #1021

Merged
merged 2 commits into from
Mar 11, 2024
Merged

[e2e-tests] Add security scan check to quay plugin suite #1021

merged 2 commits into from
Mar 11, 2024

Conversation

jrichter1
Copy link
Contributor

Description

Extend quay plugin e2e suite to include the changes contributed by RHTAP

Which issue(s) does this PR fix

https://issues.redhat.com/browse/RHIDP-1112

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@jrichter1 jrichter1 requested a review from a team as a code owner February 27, 2024 11:30
@janus-idp Janus IDP
Copy link

janus-idp bot commented Feb 27, 2024 •
edited
Loading

backstage-showcase Tests on commit aff49db finished successfully.
View test log

@jrichter1 jrichter1 force-pushed the e2e-quay-rhtap branch 2 times, most recently from 5d0171f to 2be9b6d Compare February 27, 2024 12:15
@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1021!

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1021!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 4, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1021!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1021!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1021!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 6, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1021!

@openshift-ci openshift-ci bot added the lgtm label Mar 7, 2024
josephca
josephca approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@josephca josephca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the approved label Mar 7, 2024
@openshift-ci openshift-ci bot removed the lgtm label Mar 7, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1021!

@josephca
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 11, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gustavolira, josephca

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 852a05e into janus-idp:main Mar 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gustavolira gustavolira gustavolira approved these changes

@josephca josephca josephca approved these changes

@rnapoles-rh rnapoles-rh Awaiting requested review from rnapoles-rh

Assignees

@gustavolira gustavolira

@josephca josephca

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jrichter1 @josephca @gustavolira