Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump base images to use Node.js 20 #1048

Merged
merged 2 commits into from
Apr 29, 2024
Merged

bump base images to use Node.js 20 #1048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0dd7d1d
chore: bump base images to use Node.js 20
BethGriggs Feb 29, 2024
e74bdad
Merge branch 'main' into 20
nickboldt Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18.19.0
20.12.2
8 changes: 4 additions & 4 deletions .rhdh/docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@
# 4. add Brew metadata

# Stage 1 - Build nodejs skeleton
#@follow_tag(registry.access.redhat.com/ubi9/nodejs-18:1)
FROM registry.access.redhat.com/ubi9/nodejs-18:1-98.1711398651 AS build
#@follow_tag(registry.access.redhat.com/ubi9/nodejs-20:1)
FROM registry.access.redhat.com/ubi9/nodejs-20:1-34.1712566506 AS build
# hadolint ignore=DL3002
USER 0

Expand Down Expand Up @@ -169,8 +169,8 @@ RUN tar xzf $TARBALL_PATH/skeleton.tar.gz; tar xzf $TARBALL_PATH/bundle.tar.gz;
RUN $YARN install --frozen-lockfile --production --network-timeout 600000

# Stage 5 - Build the runner image
#@follow_tag(registry.access.redhat.com/ubi9/nodejs-18-minimal:1)
FROM registry.access.redhat.com/ubi9/nodejs-18-minimal:1-103.1711398650 AS runner
#@follow_tag(registry.access.redhat.com/ubi9/nodejs-20-minimal:1)
FROM registry.access.redhat.com/ubi9/nodejs-20-minimal:1-37.1712566503 AS runner
USER 0

ENV CONTAINER_SOURCE=/opt/app-root/src
Expand Down
4 changes: 2 additions & 2 deletions docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
# 4. add Brew metadata

# Stage 1 - Build nodejs skeleton
FROM registry.access.redhat.com/ubi9/nodejs-18:1-98.1711398651 AS skeleton
FROM registry.access.redhat.com/ubi9/nodejs-20:1-34.1712566506 AS skeleton
# hadolint ignore=DL3002
USER 0

Expand Down Expand Up @@ -96,7 +96,7 @@ COPY $EXTERNAL_SOURCE_NESTED/dynamic-plugins.default.yaml ./
RUN $YARN install --frozen-lockfile --production --network-timeout 600000

# Stage 5 - Build the runner image
FROM registry.access.redhat.com/ubi9/nodejs-18-minimal:1-103.1711398650 AS runner
FROM registry.access.redhat.com/ubi9/nodejs-20-minimal:1-37.1712566503 AS runner
USER 0

ENV CONTAINER_SOURCE=/opt/app-root/src
Expand Down
2 changes: 1 addition & 1 deletion docker/prow.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
# This Dockerfile used to run tests on OpenShift CI (Prow)

# Stage 1 - Build nodejs skeleton
FROM registry.access.redhat.com/ubi9/nodejs-18:1-98.1711398651 AS skeleton
FROM registry.access.redhat.com/ubi9/nodejs-20:1-34.1712566506 AS skeleton
# hadolint ignore=DL3002
USER 0

Expand Down