Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E: upload Playwright report and add view report link to PR #1068

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

kadel
Copy link
Member

@kadel kadel commented Mar 10, 2024

Description

Upload Playwright reports to the same location as logs are uploaded and add a link to view and download the report to the PR. (see: #1068 (comment))

Which issue(s) does this PR fix

  • Fixes #?

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@kadel kadel requested a review from a team as a code owner March 10, 2024 15:09
Copy link

janus-idp bot commented Mar 10, 2024

backstage-showcase Tests on commit d7df36e finished with errors.
View test log
View Playwright report
Download Playwright report

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1068!

chore(ci): fix link to Playwright report in GitHub comment
Copy link

sonarcloud bot commented Mar 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1068!

Copy link
Contributor

@josephca josephca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

openshift-ci bot commented Mar 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gustavolira, josephca

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 7793a3e into janus-idp:main Mar 12, 2024
6 checks passed
ciiay added a commit to ciiay/backstage-showcase that referenced this pull request Mar 22, 2024
Signed-off-by: Yi Cai <yicai@redhat.com>

added card styles to match pf5

Signed-off-by: Yi Cai <yicai@redhat.com>

E2E: upload Playwright report and add view report link to PR (janus-idp#1068)

* chore(ci): upload Playwright report and add view report link to PR

* Update functions.sh

chore(ci): fix link to Playwright report in GitHub comment

chore(deps): bump jose (janus-idp#1058)

Bumps [jose](https://github.com/panva/jose) from 4.15.4 to 4.15.5.
- [Release notes](https://github.com/panva/jose/releases)
- [Changelog](https://github.com/panva/jose/blob/v4.15.5/CHANGELOG.md)
- [Commits](panva/jose@v4.15.4...v4.15.5)

---
updated-dependencies:
- dependency-name: jose
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

chore(deps): bump jose from 4.15.4 to 4.15.5 (janus-idp#1059)

Bumps [jose](https://github.com/panva/jose) from 4.15.4 to 4.15.5.
- [Release notes](https://github.com/panva/jose/releases)
- [Changelog](https://github.com/panva/jose/blob/v4.15.5/CHANGELOG.md)
- [Commits](panva/jose@v4.15.4...v4.15.5)

---
updated-dependencies:
- dependency-name: jose
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Support `resolvePackagePath` for dynamic backend plugins. (janus-idp#1071)

Signed-off-by: David Festal <dfestal@redhat.com>

Fix topology height

Signed-off-by: Yi Cai <yicai@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants