plugin-scalprum-backend: replace mock-fs with @backstage/backend-test… #1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-utils mock-fs does not work with Node.js 20.8.0 and later. This commit replaces it with @backstage/backend-test-utils from upstream. Signed-off-by: Beth Griggs <bethanyngriggs@gmail.com>
|
|
The image is available at: |
|
backstage-showcase Tests on commit c133b99 finished successfully. |
davidfestal
approved these changes
Mar 18, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidfestal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ciiay
pushed a commit
to ciiay/backstage-showcase
that referenced
this pull request
Mar 22, 2024
…-utils (janus-idp#1080) mock-fs does not work with Node.js 20.8.0 and later. This commit replaces it with @backstage/backend-test-utils from upstream. Signed-off-by: Beth Griggs <bethanyngriggs@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…-utils
mock-fs does not work with Node.js 20.8.0 and later, so we replace it with @backstage/backend-test-utils from upstream.
First time digging into this code so 🤞🏻
Description
Please explain the changes you made here.
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer