Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(audit log): add audit log event stream #1172

Merged
merged 3 commits into from
Apr 15, 2024
Merged

Conversation

schultzp2020
Copy link
Member

@schultzp2020 schultzp2020 commented Apr 10, 2024

Description

Please explain the changes you made here.

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Signed-off-by: Paul Schultz <pschultz@pobox.com>
@schultzp2020 schultzp2020 requested a review from a team as a code owner April 10, 2024 20:48
@schultzp2020 schultzp2020 marked this pull request as draft April 10, 2024 20:48
@schultzp2020
Copy link
Member Author

@davidfestal can you help me debug why getPackages isn't working properly?

backend:start: Loading config from MergedConfigSource{FileConfigSource{path="C:\Programming\Work\backstage-showcase\app-config.yaml"}, FileConfigSource{path="C:\Programming\Work\backstage-showcase\app-config.local.yaml"}, EnvConfigSource{count=0}}
backend:start: C:\Programming\Work\backstage-showcase\node_modules\@manypkg\tools\dist\manypkg-tools.cjs.dev.js:540
backend:start:       const packageGlobs = Array.isArray(pkgJson.workspaces) ? pkgJson.workspaces : pkgJson.workspaces.packages;
backend:start: 
                         ^
backend:start: 
backend:start: TypeError: Cannot read properties of undefined (reading 'packages')
backend:start:     at Object.getPackages (C:\Programming\Work\backstage-showcase\node_modules\@manypkg\tools\dist\manypkg-tools.cjs.dev.js:540:104)
backend:start:     at async getPackages (C:\Programming\Work\backstage-showcase\packages\backend\node_modules\@manypkg\get-packages\dist\manypkg-get-packages.cjs.dev.js:34:20)
backend:start:     at Object.factory (c:\Programming\Work\backstage-showcase\packages\backend\src\logger\customLogger.ts:111:22)
backend:start:     at async Promise.all (index 1)
backend:start:     at async Promise.all (index 1)
backend:start:     at BackendInitializer.doStart_fn (C:\Programming\Work\backstage-showcase\node_modules\@backstage\backend-app-api\src\wiring\BackendInitializer.ts:159:30)
backend:start:     at BackendInitializer.start (C:\Programming\Work\backstage-showcase\node_modules\@backstage\backend-app-api\src\wiring\BackendInitializer.ts:149:5)
backend:start:     at BackstageBackend.start (C:\Programming\Work\backstage-showcase\node_modules\@backstage\backend-app-api\src\wiring\BackstageBackend.ts:42:11)
backend:start: 
backend:start: Node.js v18.19.0

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1172!

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1172!

Signed-off-by: Paul Schultz <pschultz@pobox.com>
@schultzp2020 schultzp2020 marked this pull request as ready for review April 15, 2024 17:31
@openshift-ci openshift-ci bot requested a review from davidfestal April 15, 2024 17:31
Copy link

sonarcloud bot commented Apr 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

openshift-ci bot commented Apr 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidfestal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1172!

@openshift-merge-bot openshift-merge-bot bot merged commit 5517df0 into main Apr 15, 2024
8 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the audit-log branch April 15, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants