chore(deps): fail the build if workspace dirty after a yarn install (yarn.lock changed) (RHIDP-1203, RHIDP-1204)

[nickboldt]

What does this PR do?

chore(deps): fail the build if workspace dirty after a yarn install (yarn.lock changed) (RHIDP-1203, RHIDP-1204)

Signed-off-by: Nick Boldt nboldt@redhat.com

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

N/A (or see commit message above for issue number)

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

• The Eclipse Contributor Agreement is valid
• Code produced is complete
• Code builds without errors
• Tests are covering the bugfix
• The repository devfile is up to date and works, if one exists
• Sections What issues does this PR fix or reference and How to test this PR completed
• Relevant user documentation updated
• Relevant contributing documentation updated
• CI/CD changes implemented, documented and communicated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

[github-actions]

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1175!

[gashcrumb]

Interesting, when I try this locally, I don't get changed files. Let me test again with a totally clean repository and see. I think ideally I should get the same result locally as the build does in the PR.

[gashcrumb]

Ah, I see actually having a changed app-config.yaml is expected:

unless we change this line and whatever relies on this to use app-config.local.yaml instead. We could try this now but I don't know if this will break something else, otherwise we could ignore the two files for the time being and raise an issue to tidy this up in the future.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gashcrumb
Once this PR has been reviewed and has the lgtm label, please ask for approval from nickboldt. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[github-actions]

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1175!