Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update to backstage 1.26.x #1221

Merged
merged 12 commits into from
May 13, 2024
Merged

chore(deps): update to backstage 1.26.x #1221

merged 12 commits into from
May 13, 2024

Conversation

schultzp2020
Copy link
Member

Description

Please explain the changes you made here.

Which issue(s) does this PR fix

  • Fixes #?

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@schultzp2020 schultzp2020 requested a review from a team as a code owner April 30, 2024 20:46
@schultzp2020 schultzp2020 marked this pull request as draft April 30, 2024 20:46
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 30, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from schultzp2020. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@schultzp2020
fix tsc issues
fa1abc4 
Signed-off-by: Paul Schultz <pschultz@pobox.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 1, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1221!

@schultzp2020
update to backstage 1.26.5
e8c25e3 
Signed-off-by: Paul Schultz <pschultz@pobox.com>
@schultzp2020
Merge branch 'main' of https://github.com/janus-idp/backstage-showcase …
4b79fb7 
…into update-1.26.x
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 3, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1221!

@PatAKnight PatAKnight mentioned this pull request May 3, 2024
Merged
@schultzp2020
Merge branch 'main' of https://github.com/janus-idp/backstage-showcase …
1bff09d 
…into update-1.26.x

Signed-off-by: Paul Schultz <pschultz@pobox.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 3, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1221!

@schultzp2020
Merge branch 'main' of https://github.com/janus-idp/backstage-showcase …
a544979 
…into update-1.26.x

Signed-off-by: Paul Schultz <pschultz@pobox.com>
@schultzp2020
remove unnecessary deps
b34ebeb 
Signed-off-by: Paul Schultz <pschultz@pobox.com>
@schultzp2020
remove unnecessary dep
1a0c58c 
Signed-off-by: Paul Schultz <pschultz@pobox.com>
@schultzp2020
update files
93c441c 
Signed-off-by: Paul Schultz <pschultz@pobox.com>
@schultzp2020
Merge branch 'main' of https://github.com/janus-idp/backstage-showcase …
3c9376c 
…into update-1.26.x

Signed-off-by: Paul Schultz <pschultz@pobox.com>
@schultzp2020 schultzp2020 marked this pull request as ready for review May 10, 2024 15:00
@openshift-ci openshift-ci bot requested a review from josephca May 10, 2024 15:00
@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1221!

nickboldt
nickboldt reviewed May 10, 2024
View reviewed changes
Copy link
Member

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skimmed, but 113 files (including a lot of yarn locks) is too much to manually review.

looks good, especially since I see you're switching to the new backstage-community versions of deps.

@schultzp2020
Merge branch 'main' of https://github.com/janus-idp/backstage-showcase …
e345728 
…injanus-idp/backstage-showcase into update-1.26.x

Signed-off-by: Paul Schultz <pschultz@pobox.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1221!

@nickboldt nickboldt merged commit 85e6fdf into main May 13, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickboldt nickboldt nickboldt left review comments

@Zaperex Zaperex Zaperex left review comments

@kadel kadel Awaiting requested review from kadel

@rnapoles-rh rnapoles-rh Awaiting requested review from rnapoles-rh

@josephca josephca Awaiting requested review from josephca

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@schultzp2020 @nickboldt @Zaperex @openshift-merge-robot