-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(app) RHIDP-1803 enable field extensions #1253
Conversation
Skipping CI for Draft Pull Request. |
b58abf8
to
0623d74
Compare
The image is available at: |
/approve |
This commit enables support for Scaffolder field extensions. A plugin can export a field extension as documented and then configure it to be included in the list of enabled scaffolder field extensions using the following configuration: ```yaml dynamicPlugins: frontend: my-plugin: scaffolderFieldExtensions: - importName: SomeExportedFieldExtension ``` Signed-off-by: Stan Lewis <gashcrumb@gmail.com>
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidfestal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The image is available at: |
I was able to launch janus-idp locally using as auth provider .... github
The fieldExtensions are working if we add as config
|
That's great news @cmoulliard! This will need plenty of testing as I've only tried the most minimal use case, so raise issues if you run into anything. Thanks! |
Description
This commit enables support for Scaffolder field extensions. A plugin
can export a field extension as documented and then configure it to be
included in the list of enabled scaffolder field extensions using the
following configuration:
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer
There's a really simple extension in this package that can be used for a quick test. You can import this template and then use this configuration: