Pull in scaffolder-relation-processor plugin from @backstage-community to 1.2.x branch of janus-showcase because it is the new scope. #1367
Conversation
…nity because it is the new scope.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
The image is available at: |
Fortune-Ndlovu
changed the title
/retest-required |
|
@Fortune-Ndlovu: Fortune-Ndlovu unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
The image is available at: |
|
/test e2e-tests |
…ation-processor to the dependencies section rather than the peerDependencies section for automatic installtion and direct dependency
|
The image is available at: |
|
/test e2e-tests |
|
@Fortune-Ndlovu: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
I'm confused. The new https://github.com/backstage/community-plugins/blob/main/workspaces/scaffolder-relation-processor/package.json#L3 is at version 1.0.0 and is marked private. But we have https://www.npmjs.com/package/@backstage-community/plugin-catalog-backend-module-scaffolder-relation-processor 0.2.0 from 21 days ago too. @Zaperex how is the 1.0.0 package.json related to the 0.2.0 release? Also there's a 1.1.1 version of https://www.npmjs.com/package/@janus-idp/backstage-plugin-catalog-backend-module-scaffolder-relation-processor-dynamic available from 20 days ago, which is presumably newer than the 1.0.3 or 0.2.0 versions in this PR. |
Ah so the
Technically it's newer just because the |
|
OK so I'm hearing that https://github.com/backstage/community-plugins/blob/main/workspaces/scaffolder-relation-processor/plugins/catalog-backend-module-scaffolder-relation-processor/package.json#L4 should be bumped to 1.1.2 so it's larger than the 1.1.1 version out there, to eliminate the confusion around "0.2 is newer than 1.1" Would you agree with that ? |
|
one main concern would just be semvar being broken, but when did backstage ever follow it 😂 |
There was a problem hiding this comment.
Blocked by some migration work to be done in https://issues.redhat.com/browse/RHIDP-3162
This PR pulls in the scaffolder-relation-processor plugin from the backstage-community repository into the 1.2.x branch of janus-showcase. This includes updating the dynamic-plugins-imports/package.json file to reference the correct version of the plugin.
Changes Made
Updated dynamic-plugins-imports/package.json to include the following dependency because of its newly allocated scope.
"@backstage-community/plugin-catalog-backend-module-scaffolder-relation-processor": "0.2.0"Which issue(s) does this PR fix
The scaffolder-relation-processor plugin is required for enhancing the scaffolding capabilities of the catalog backend module. This update ensures that the janus-showcase project is using the latest version of this plugin from the backstage-community repository in the new scope defined.
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer