-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHIDP-744 [Test Automation] Automate RHDH theme customization - E2E #1368
Conversation
The image is available at: |
The image is available at: |
/lgtm |
The image is available at: |
e2e-tests/playwright/e2e/plugins/custom-theme/theme-verifier.ts
Outdated
Show resolved
Hide resolved
The image is available at: |
The image is available at: |
The image is available at: |
The image is available at: |
Refactor custom theme E2E test and update uihelper functions Improve error handling in UIhelper.ts Added try-catch to handle potential errors while scrolling elements into view during end-to-end testing in UIhelper.ts. A warning will now be logged in the console if an error occurs to aid debugging and troubleshooting. Signed-off-by: Gustavo Lira <guga.java@gmail.com>
The image is available at: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: albarbaro, schultzp2020 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Refactor custom theme E2E test and update uihelper functions
The custom theme end-to-end test was refactored to be more focused and reliable. The 'UIhelper' was enriched with new functions that improve reusability in tests. Also, configuration for application theming and authentication methods were updated.
Refactor custom theme E2E test and update uihelper functions
The custom theme end-to-end test was refactored to be more focused and reliable. The 'UIhelper' was enriched with new functions that improve reusability in tests. Also, configuration for application theming and authentication methods were updated.
Which issue(s) does this PR fix
RHIDP-744
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer