Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHIDP-744 [Test Automation] Automate RHDH theme customization - E2E #1368

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

gustavolira
Copy link
Contributor

Description

Refactor custom theme E2E test and update uihelper functions

The custom theme end-to-end test was refactored to be more focused and reliable. The 'UIhelper' was enriched with new functions that improve reusability in tests. Also, configuration for application theming and authentication methods were updated.

Refactor custom theme E2E test and update uihelper functions

The custom theme end-to-end test was refactored to be more focused and reliable. The 'UIhelper' was enriched with new functions that improve reusability in tests. Also, configuration for application theming and authentication methods were updated.

Which issue(s) does this PR fix

RHIDP-744

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Copy link
Contributor

github-actions bot commented Jul 4, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1368!

Copy link
Contributor

github-actions bot commented Jul 4, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1368!

@albarbaro
Copy link
Contributor

/lgtm
/approve

Copy link
Contributor

github-actions bot commented Jul 4, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1368!

Copy link
Contributor

github-actions bot commented Jul 8, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1368!

Copy link
Contributor

github-actions bot commented Jul 8, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1368!

Copy link
Contributor

github-actions bot commented Jul 8, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1368!

Copy link
Contributor

github-actions bot commented Jul 9, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1368!

Refactor custom theme E2E test and update uihelper functions

Improve error handling in UIhelper.ts

Added try-catch to handle potential errors while scrolling elements into view during end-to-end testing in UIhelper.ts. A warning will now be logged in the console if an error occurs to aid debugging and troubleshooting.

Signed-off-by: Gustavo Lira <guga.java@gmail.com>
Copy link
Contributor

github-actions bot commented Jul 9, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1368!

Copy link
Member

@schultzp2020 schultzp2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Copy link

openshift-ci bot commented Jul 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: albarbaro, schultzp2020

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 3582db4 into janus-idp:main Jul 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants